Fix scala plugin REPL incompatibility; separately download and configure REPL for scala >= 3.8#1272
Open
murhum1 wants to merge 2 commits into
Open
Fix scala plugin REPL incompatibility; separately download and configure REPL for scala >= 3.8#1272murhum1 wants to merge 2 commits into
murhum1 wants to merge 2 commits into
Conversation
…e REPL for scala >= 3.8
Member
OlliKiljunen
left a comment
OlliKiljunen
left a comment
There was a problem hiding this comment.
Thank you for the PR! The code looks fine. Before approving, I'd like to hear your opinion on my comment in Component.kt file.
Author
Thanks for the review! Moved the functionality to |
OlliKiljunen
approved these changes
Jun 4, 2026
Member
OlliKiljunen
left a comment
OlliKiljunen
left a comment
There was a problem hiding this comment.
Thank you for considering my comments. I think this can be merged now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the PR
As mentioned, I was unsure whether manually downloading REPL was even necessary since it looks to be present in the downloaded Scala SDK zip and as a dependency in scala.jar's MANIFEST.MF classpath, but I had the code present already and it was deemed safer to do a manual download anyway, as we figured there was no guarantee the repl jar would be there in the future as well.